Overview

Supports git sources in cocoapods. Intention is to reach parity between CLIv1, and CLIv2.

It also does minor refractor.

Acceptance criteria

• Cocoapod sourced from git sources, result in git locator (as opposed to current behaviour of always using Pod)

Testing plan

1. Create a Pod project (example Podfile provided below)
2. Enforce git source for the pod (pod update)
3. Run analysis, and inspect locators

Podfile

# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'someproj' do
  # Comment the next line if you don't want to use dynamic frameworks
  use_frameworks!

  # Pods for someproj
  pod 'Alamofire-test', :git => 'https://github.com/meghfossa/Alamo-fire.git'
  pod 'GoogleUtilities' 

  target 'someproj WatchKit AppTests' do
    inherit! :search_paths
    # Pods for testing
  end

  target 'someproj WatchKit AppUITests' do
    # Pods for testing
  end

  target 'someprojTests' do
    inherit! :search_paths
    # Pods for testing
  end

  target 'someprojUITests' do
    # Pods for testing
  end

end

Risks

Although, current documentation on cocoapod resolution is not ideal, I think potential risk is not resolving when subspecs are sourced from original git source. E.g ExampleKit is sourced from privateGit, and then ExampleKit/Logger should also be sourced from such.

Currently, this is also not supported in CLI v1. I intend to address this in subsequent PR.

References

Works on https://github.com/fossas/team-analysis/issues/721

Checklist

• I added tests for this PR's change (or confirmed tests are not viable).
• If this PR introduced a user-visible change, I added documentation into docs/.
• I updated Changelog.md if this change is externally facing. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
• I linked this PR to any referenced GitHub issues, if they exist.